Skip to content

Add all JSON Schemes for Tekton resources#367

Merged
evidolob merged 2 commits intomasterfrom
all-json-schemes
Jul 17, 2020
Merged

Add all JSON Schemes for Tekton resources#367
evidolob merged 2 commits intomasterfrom
all-json-schemes

Conversation

@evidolob
Copy link
Copy Markdown
Collaborator

@evidolob evidolob commented Jul 16, 2020

PR provides all schemes Tekton resources, schemes taken from redhat-developer/intellij-tekton#148

Fix: #258

Depends on redhat-developer/vscode-yaml#315

Do not merge until redhat-developer/vscode-yaml#315 is merged and released

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob self-assigned this Jul 16, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 16, 2020

Codecov Report

Merging #367 into master will decrease coverage by 0.24%.
The diff coverage is 24.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
- Coverage   73.85%   73.60%   -0.25%     
==========================================
  Files          47       47              
  Lines        3435     3452      +17     
  Branches      638      641       +3     
==========================================
+ Hits         2537     2541       +4     
- Misses        898      911      +13     
Impacted Files Coverage Δ
src/yaml-support/tkn-yaml-scheme-generator.ts 28.57% <11.11%> (-3.14%) ⬇️
src/yaml-support/tkn-yaml.ts 87.13% <15.38%> (-3.17%) ⬇️
src/yaml-support/tkn-yaml-schema.ts 45.58% <27.27%> (+3.16%) ⬆️
src/yaml-support/tkn-scheme-storage.ts 94.11% <80.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd340e...58e3f3b. Read the comment docs.

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@@ -0,0 +1,2310 @@
{
"$schema": "http://json-schema.org/draft-04/schema#",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep file name as v1alpha1? and how I can generate this JSON?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I say in description, I take schemas from redhat-developer/intellij-tekton#148
intellij-tekton has code to generate schemas.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep file name as v1beta1 instead of v1alpha1? as we are supporting v1beta1 for most of the cases?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have 2 schemes one for v1alpha1 another for v1beta1

@evidolob evidolob merged commit a57b91d into master Jul 17, 2020
@evidolob evidolob deleted the all-json-schemes branch July 17, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide JSON scheme for all Tekton resources

3 participants