Fix crash of extension when proxy settings address has wrong format

[angelozerr]

This PR should fix the following problem:

2024-11-22 14:07:45.651 [error] Activating extension redhat.vscode-xml failed due to an error:
2024-11-22 14:07:45.651 [error] TypeError: Cannot read properties of null (reading '1')
	at t.getProxySettings (/Users/userid/.vscode/extensions/redhat.vscode-xml-0.27.2024111708-darwin-arm64/dist/extension.js:2:354116)

reported at #154 (comment)

I think to reproduce the problem, proxy address have a wrong format (don't start with https://)

A simple test that I did in debug is:

const HOST_AND_PORT_EXTRACTOR = /https?:\/\/([^:/]+)(?::([0-9]+))?/;
HOST_AND_PORT_EXTRACTOR .exec('foo") // -> returns undefined

[datho7561]

This change looks pretty good so far.

I think, if we want to support something like 192.168.1.23:9090 as the proxy, we can use this regex:

(?:https?:\/\/)?([^:/]+)(?::([0-9]+))?

which just wraps the https:// part in a non-capturing group and makes it optional.

From what I can tell, we don't use the http:// or https:// part of the url anyways, so it shouldn't matter if it's left out.

[angelozerr]

I have tried the const HOST_AND_PORT_EXTRACTOR = (?:https?://)?([^:/]+)(?::([0-9]+))?;

but it seems it is not a valid regexp

[datho7561]

ahh I think you need to surround it in //:

const HOST_AND_PORT_EXTRACTOR = /(?:https?://)?([^:/]+)(?::([0-9]+))?/;

[datho7561]

diff --git a/src/settings/proxySettings.ts b/src/settings/proxySettings.ts
index 3cbcf38..6ee7d0c 100644
--- a/src/settings/proxySettings.ts
+++ b/src/settings/proxySettings.ts
@@ -152,7 +152,7 @@ export function jvmArgsContainsProxySettings(jvmArgs: string): boolean {
   );
 }
 
-const HOST_AND_PORT_EXTRACTOR = /https?:\/\/([^:/]+)(?::([0-9]+))?/;
+const HOST_AND_PORT_EXTRACTOR = /(?:https?:\/\/)?([^:/]+)(?::([0-9]+))?/;
 
 const JVM_PROXY_HOST = 'http.proxyHost';
 const JVM_PROXY_PORT = 'http.proxyPort';

[angelozerr]

Thanks @datho7561 !

It seems it is working pretty well.

Please merge the PR if you think it is good.

[datho7561]

Thanks for fixing this, Angelo!