Drop support for Alpine Linux-specific version#1083
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom May 9, 2025
Merged
Drop support for Alpine Linux-specific version#1083datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561 merged 1 commit intoredhat-developer:mainfrom
Conversation
Contributor
Author
|
|
4d802db to
1ff7433
Compare
rgrunber
reviewed
May 9, 2025
1ff7433 to
e41c2f3
Compare
rgrunber
approved these changes
May 9, 2025
Member
|
vscode-xml/src/server/binary/binaryServerStarter.ts Lines 209 to 218 in 62f6a66 |
We can't build a binary version of the language server for Alpine Linux any more due to bugs/limitations in GraalVM and changes to the runners in GitHub Actions. It's _probably_ okay to drop Alpine Linux support, since Alpine Linux is usually used on servers instead of as a desktop operating system, and it's a real pain to set up as a desktop operating system. Alpine Linux users should still be able to use the extension if they install Java. Signed-off-by: David Thompson <davthomp@redhat.com>
e41c2f3 to
5cb633e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't build a binary version of the language server for Alpine Linux any more due to bugs/limitations in GraalVM and changes to the runners in GitHub Actions.
It's probably okay to drop Alpine Linux support, since Alpine Linux is usually used on servers instead of as a desktop operating system, and it's a real pain to set up as a desktop operating system.
Alpine Linux users should still be able to use the extension if they install Java.