Rename telemetry events#453
Merged
fbricon merged 1 commit intoredhat-developer:masterfrom Apr 16, 2021
Merged
Conversation
Contributor
Author
datho7561
commented
Apr 14, 2021
datho7561
force-pushed
the
change-download-event-name
branch
from
61805c6 to
8fa73cb
Compare
Collaborator
|
Please use . instead of _ as separator |
fbricon
reviewed
Apr 14, 2021
fbricon
reviewed
Apr 14, 2021
fbricon
reviewed
Apr 14, 2021
Contributor
Author
I thought that there was some issue with using |
datho7561
force-pushed
the
change-download-event-name
branch
from
8fa73cb to
d6c4e32
Compare
Collaborator
No the issue is with |
fbricon
reviewed
Apr 14, 2021
fbricon
reviewed
Apr 14, 2021
Contributor
Author
Okay. LemMinX's reporting is also inconsistent then (lemminx uses |
Use `.` consistently as the separator in event names. Prefix event names with `xml.`. Group the binary download events into `xml_binary_download`. Add a parameter `status` that indicates if the download succeeded, failed or was aborted. Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
change-download-event-name
branch
from
d6c4e32 to
cf4ed6a
Compare
datho7561
changed the title
Contributor
Author
fbricon
approved these changes
Apr 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
.consistently as the separator in event names. Prefix event names withxml.. Group the binary download events intoxml_binary_download. Add a parameterstatusthat indicates if the download succeeded, failed or was aborted.Signed-off-by: David Thompson davthomp@redhat.com