Skip to content

Support shouldLanguageServerExitOnShutdown capability#530

Merged
datho7561 merged 1 commit intoredhat-developer:masterfrom
datho7561:support-exit-on-shutdown
Jun 25, 2021
Merged

Support shouldLanguageServerExitOnShutdown capability#530
datho7561 merged 1 commit intoredhat-developer:masterfrom
datho7561:support-exit-on-shutdown

Conversation

@datho7561
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 commented Jun 25, 2021

Supports the capability, which means that language server shuts down when shutdown is received instead of when exit is received.

See eclipse-lemminx/lemminx#1070

Signed-off-by: David Thompson davthomp@redhat.com

@datho7561 datho7561 force-pushed the support-exit-on-shutdown branch from 7549672 to ce02b2b Compare June 25, 2021 14:54
@datho7561 datho7561 marked this pull request as ready for review June 25, 2021 15:00
@datho7561 datho7561 marked this pull request as draft June 25, 2021 15:21
@datho7561
Copy link
Copy Markdown
Contributor Author

Need to change package.json to lemminx 0.17.1

Supports the capability, which means that language server shuts down
when `shutdown` is received instead of when `exit` is received.

See eclipse-lemminx/lemminx#1070

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the support-exit-on-shutdown branch from ce02b2b to 1d99ce1 Compare June 25, 2021 16:11
@datho7561 datho7561 marked this pull request as ready for review June 25, 2021 16:11
@datho7561 datho7561 requested a review from rgrunber June 25, 2021 17:22
Copy link
Copy Markdown
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@datho7561 datho7561 added this to the 0.17.0 milestone Jun 25, 2021
@datho7561 datho7561 merged commit 4912bfa into redhat-developer:master Jun 25, 2021
@datho7561 datho7561 deleted the support-exit-on-shutdown branch June 25, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants