Skip to content

Report only XML syntax error for *.exsd files#782

Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom
angelozerr:exsd-only-xml-syntax
Oct 18, 2022
Merged

Report only XML syntax error for *.exsd files#782
datho7561 merged 1 commit intoredhat-developer:mainfrom
angelozerr:exsd-only-xml-syntax

Conversation

@angelozerr
Copy link
Copy Markdown
Contributor

@angelozerr angelozerr commented Oct 6, 2022

Report only XML syntax error for *.exsd files

Signed-off-by: azerr azerr@redhat.com

@angelozerr angelozerr mentioned this pull request Oct 6, 2022
Merged
@datho7561
Copy link
Copy Markdown
Contributor

datho7561 commented Oct 11, 2022 •
edited
Loading

I think that this setting needs some documentation, especially since it doesn't ignore errors coming from <?xml-model processing instructions yet

@angelozerr
Copy link
Copy Markdown
Contributor Author

angelozerr commented Oct 11, 2022

I think that this setting needs some documentation, especially since it doesn't ignore errors coming from <?xml-model processing instructions yet

It is a bug,so we should create an issue on LemMinx side

@datho7561
Copy link
Copy Markdown
Contributor

datho7561 commented Oct 11, 2022

I opened eclipse-lemminx/lemminx#1312, but we should document the behaviour of the setting

@angelozerr
Copy link
Copy Markdown
Contributor Author

angelozerr commented Oct 11, 2022

I opened eclipse-lemminx/lemminx#1312, but we should document the behaviour of the setting

Thanks!

@datho7561 datho7561 assigned datho7561 and unassigned datho7561 Oct 13, 2022
@datho7561 datho7561 self-requested a review October 13, 2022 16:36
@datho7561
Copy link
Copy Markdown
Contributor

datho7561 commented Oct 13, 2022

@angelozerr do you think you could add some documentation for this setting in the PR?

@angelozerr angelozerr force-pushed the exsd-only-xml-syntax branch from 604740f to 326cbd9 Compare October 17, 2022 23:59
@angelozerr
Report only XML syntax error for *.exsd files
326cbd9 
Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Copy Markdown
Contributor Author

angelozerr commented Oct 18, 2022

@angelozerr do you think you could add some documentation for this setting in the PR?

Sorry to do that in late, fixed.

datho7561
datho7561 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, Angelo!

@datho7561 datho7561 added this to the 0.22.0 milestone Oct 18, 2022
@datho7561 datho7561 added the enhancement New feature or request label Oct 18, 2022
@datho7561 datho7561 merged commit 29457ac into redhat-developer:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.22.0

Development

Successfully merging this pull request may close these issues.

2 participants

@angelozerr @datho7561
⚡