Update documentation and settings for experimental formatter to default#823
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Dec 5, 2022
Merged
Conversation
JessicaJHee
force-pushed
the
udpate-exp-doc
branch
from
4c7587b to
1086a71
Compare
datho7561
requested changes
Nov 28, 2022
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks pretty good! I just noticed some wording that I think could be improved, let me know what you think. Everything else looks good.
Signed-off-by: Jessica He <jhe@redhat.com>
JessicaJHee
force-pushed
the
udpate-exp-doc
branch
from
1086a71 to
7998e25
Compare
Contributor
|
Looks good, just want to make sure it works with the lemminx change. I'll check that first thing tomorrow. |
datho7561
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xml.format.experimentalsettingsxml.format.legacyto revert to old formatterFixes eclipse-lemminx/lemminx#1377
Requires eclipse-lemminx/lemminx#1381
Signed-off-by: Jessica He jhe@redhat.com