multiple support for xml.references"#855
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Jan 13, 2023
Merged
Conversation
angelozerr
force-pushed
the
references-multiple
branch
from
068e356 to
4557ef9
Compare
angelozerr
force-pushed
the
references-multiple
branch
4 times, most recently
from
07433ee to
8a4f769
Compare
datho7561
requested changes
Jan 13, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks pretty good. I think the wording of the settings that apply to multiple expressions could be improved
angelozerr
force-pushed
the
references-multiple
branch
from
8a4f769 to
66ba98b
Compare
Signed-off-by: azerr <azerr@redhat.com>
datho7561
approved these changes
Jan 13, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Angelo!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multiple support for xml.references"
Signed-off-by: azerr azerr@redhat.com