Fix indentation in XML/XSD files#900
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom May 3, 2023
Merged
Conversation
angelozerr
reviewed
May 3, 2023
Contributor
|
See my comment otherwise it LGTM @JessicaJHee if you have time could you test the PR of @datho7561 and merge it if it is good to have a prerlease tomorrow please. |
JessicaJHee
approved these changes
May 3, 2023
Member
JessicaJHee
left a comment
JessicaJHee
left a comment
There was a problem hiding this comment.
I've tested this PR and fixes the issue as expected. Once Angelo's comment is addressed, I think this is good to go! Thanks for providing a fix so quickly!
Make sure to upcast `string|DocumentFilter` correctly when setting indentation rules. Fixes redhat-developer#899
datho7561
force-pushed
the
899-auto-indent-fix
branch
from
4664d8d to
4b1f693
Compare
Contributor
|
Thanks so much @datho7561 ! |
Contributor
|
Thanks @JessicaJHee for your fast review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to upcast
string|DocumentFiltercorrectly when setting indentation rules.Fixes #899