Closed
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Contributor
|
The linked issue is about building and publishing a docker image of yaml-language-server onto quay that supports arm64. The vscode extension should already support arm64. I can switch over to my mac and check. I think something needs to be changed in this file: https://github.com/redhat-developer/yaml-language-server/blob/main/.github/workflows/release.yaml#L78 |
Contributor
|
I double checked, the extension already works on macOS ARM 64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support ARM64
What issues does this PR fix or reference?
redhat-developer/yaml-language-server#997
Is it tested? How?
NA