Skip to content

Fix build failure due to prettier error#1118

Merged
msivasubramaniaan merged 1 commit intoredhat-developer:mainfrom
datho7561:prettier-build-failure
Apr 30, 2025
Merged

Fix build failure due to prettier error#1118
msivasubramaniaan merged 1 commit intoredhat-developer:mainfrom
datho7561:prettier-build-failure

Conversation

@datho7561
Copy link
Copy Markdown
Contributor

What does this PR do?

Fix the prettier error (error generated due to code formatting )

What issues does this PR fix or reference?

#1117

Is it tested? How?

CI

Fixes redhat-developer#1117

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561
Copy link
Copy Markdown
Contributor Author

The integration tests are passing locally for me, so I'm going to try rerunning them. If these tests are flaky, perhaps we should disable them, since they hid a legitimate build failure. However, they are not flaky locally, maybe this is a GitHub Action specific issue that can be addressed?

Copy link
Copy Markdown
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msivasubramaniaan msivasubramaniaan merged commit 0533ac7 into redhat-developer:main Apr 30, 2025
1 of 6 checks passed
@datho7561 datho7561 deleted the prettier-build-failure branch April 30, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants