Add formatting option for trailing comma#1123
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom May 13, 2025
Merged
Add formatting option for trailing comma#1123datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561 merged 1 commit intoredhat-developer:mainfrom
Conversation
Contributor
Author
|
@msivasubramaniaan let me know if I should merge this. This is the setting that's needed to use redhat-developer/yaml-language-server#1063 |
msivasubramaniaan
requested changes
May 12, 2025
datho7561
force-pushed
the
trailing-comma-option
branch
from
a4809ee to
d763fdd
Compare
See redhat-developer/yaml-language-server#1063, this PR requires that PR in order to work. Fixes redhat-developer#1112 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
trailing-comma-option
branch
from
d763fdd to
3190c8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an option
yaml.format.trailingCommato set if trailing commas should be used JSON-style blocks like this:See redhat-developer/yaml-language-server#1063, this PR requires that PR in order to work.
What issues does this PR fix or reference?
Fixes #1112
Is it tested? How?
Unit tests in yaml-language-server. I can look into integration tests here if you think it's helpful.