Skip to content

removed yarn dependency and added NPM#1136

Merged
msivasubramaniaan merged 13 commits intoredhat-developer:mainfrom
msivasubramaniaan:move-to-npm-and-remove-yarn-dependency
Jul 18, 2025
Merged

removed yarn dependency and added NPM#1136
msivasubramaniaan merged 13 commits intoredhat-developer:mainfrom
msivasubramaniaan:move-to-npm-and-remove-yarn-dependency

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Contributor

What does this PR do?

Removed yarn and moved all the github action to npm

What issues does this PR fix or reference?

redhat-developer/yaml-language-server#1097

Is it tested? How?

NA

@datho7561
Copy link
Copy Markdown
Contributor

datho7561 commented Jul 15, 2025

The CI workflow I think still uses yarn
no that's not it I'll have to dig further to figure out what's going on

Okay, I've figured it out: .yarnrc needs to be deleted, otherwise vsce will try to build using yarn instead of npm

@msivasubramaniaan
Copy link
Copy Markdown
Contributor Author

The CI workflow I think still uses yarn no that's not it I'll have to dig further to figure out what's going on

Okay, I've figured it out: .yarnrc needs to be deleted, otherwise vsce will try to build using yarn instead of npm

Deleted .yarnrc still it expects yarn https://github.com/redhat-developer/vscode-yaml/actions/runs/16341692949/job/46165596772?pr=1136#step:7:167

@msivasubramaniaan msivasubramaniaan moved this to 🚧 In Progress in Eclipse Che Team C Backlog Jul 17, 2025
Comment thread .github/workflows/CI.yaml Outdated
with:
node-version: 20

- name: Remove Yarn on Windows
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should need to do this. What specifically is failing if you don't do this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I will remove it once code ready. I am just testing it is any yarn. If so just deleted

@rgrunber
Copy link
Copy Markdown
Member

diff --git a/package.json b/package.json
index cea2fb7..e56dc7f 100644
--- a/package.json
+++ b/package.json
@@ -255,7 +255,7 @@
     "format": "prettier --write .",
     "lint": "eslint -c .eslintrc.js --ext .ts src test",
     "test": "npm run test-compile && sh scripts/e2e.sh",
-    "ui-test": "npm run test-compile && extest setup-and-run -y out/test/ui-test/allTestsSuite.js -c 1.76.2",
+    "ui-test": "npm run test-compile && extest setup-and-run out/test/ui-test/allTestsSuite.js -c 1.76.2",
     "vscode:prepublish": "webpack --mode production",
     "watch": "webpack --mode development --watch --info-verbosity verbose",
     "test-compile": "npm run clean && tsc -p ./ && webpack --mode development",

😉

https://github.com/redhat-developer/vscode-extension-tester/wiki/Test-Setup#set-up-and-run-tests

Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. The tests are passing now!

@msivasubramaniaan msivasubramaniaan marked this pull request as ready for review July 18, 2025 05:30
@msivasubramaniaan msivasubramaniaan merged commit 4b17304 into redhat-developer:main Jul 18, 2025
5 of 9 checks passed
@msivasubramaniaan msivasubramaniaan deleted the move-to-npm-and-remove-yarn-dependency branch July 18, 2025 05:30
@msivasubramaniaan msivasubramaniaan moved this from 🚧 In Progress to ✅ Done in Eclipse Che Team C Backlog Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants