Fix filesystem watcher glob#1221
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Mar 16, 2026
Merged
Conversation
The current glob for watching workspace file changes uses `?(e)` and `?(a)` to try and mean greadily accept `e` or `a` in the extension. Unfortuately, VS Code doesn't support this syntax, so changes in `.yaml` files in the workspace aren't reported to yaml-language-server. As a result of this, if you have a JSON schema written in YAML, then any files that reference it won't be properly revalidated when you change it, and the cached version of the schema won't be invalidated properly, leading to incorrect completion results. See redhat-developer/yaml-language-server#1134 (comment) Signed-off-by: David Thompson <davthomp@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current glob for watching workspace file changes uses
?(e)and?(a)to try and mean greadily accepteorain the extension. Unfortuately, VS Code doesn't support this syntax, so changes in.yamlfiles in the workspace aren't reported to yaml-language-server.As a result of this, if you have a JSON schema written in YAML, then any files that reference it won't be properly revalidated when you change it, and the cached version of the schema won't be invalidated properly, leading to incorrect completion results.
What issues does this PR fix or reference?
See redhat-developer/yaml-language-server#1134 (comment)
Is it tested? How?
Manually