Fix debug flag breaking in latest VSCode#133
Merged
JPinkney merged 1 commit intoredhat-developer:masterfrom Oct 10, 2018
Merged
Fix debug flag breaking in latest VSCode#133JPinkney merged 1 commit intoredhat-developer:masterfrom
JPinkney merged 1 commit intoredhat-developer:masterfrom
Conversation
JPinkney
approved these changes
Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're writing an extension that depends on this one and when starting in debug mode within VSCode there is an error that causes our extension not to start:
I've tracked it down to an outdated
--debugflag passed to the language server running in Node. Now that VSCode is running v8.9.3 that has switched to--inspect.After this change starting this extension with the "Launch Extension" task then works:
