Use an output channel#327
Merged
JPinkney merged 3 commits intoredhat-developer:masterfrom Jul 24, 2020
Merged
Conversation
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Contributor
|
Is there anyway we can re-use the "YAML Support" output channel instead of creating a new one? The output channel name is automatically taken from: https://github.com/redhat-developer/vscode-yaml/blob/master/src/extension.ts#L60 |
Member
Author
|
it is possible but it will mix the information coming from the Yaml Language Server and from the extension itself. |
Contributor
|
I think that's fine. I think users will be confused when there are two output channels for the same project. By default yaml.trace.server is "off" anyways so the information from the language server is exposed only when they set yaml.trace.server to messages or verbose |
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
JPinkney
approved these changes
Jul 24, 2020
bleach31
pushed a commit
to bleach31/vscode-yaml
that referenced
this pull request
Jan 25, 2022
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for instance, currently with VS Code Kubernetes extension which is throwing error with
-file content:requires #324