Load schema content contributed by other extensions#451
Merged
evidolob merged 3 commits intoredhat-developer:masterfrom Mar 24, 2021
Merged
Load schema content contributed by other extensions#451evidolob merged 3 commits intoredhat-developer:masterfrom
evidolob merged 3 commits intoredhat-developer:masterfrom
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
JPinkney
approved these changes
Mar 16, 2021
Contributor
JPinkney
left a comment
JPinkney
left a comment
There was a problem hiding this comment.
I've been playing around with this change and it's really great 👍
| } | ||
|
|
||
| it('should handle "json-schema" url', async () => { | ||
| const docUri = getDocUri('completion/completion.yaml'); |
Member
There was a problem hiding this comment.
If you run this test against windows you might need ${path.sep}
Collaborator
Author
There was a problem hiding this comment.
No, test on windows passed successfully
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
joshuawilson
approved these changes
Mar 17, 2021
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add ability to open JSON Schema content contributed by other extensions with ExtensionAPI.
Depends on redhat-developer/yaml-language-server#424
What issues does this PR fix or reference?
redhat-developer/yaml-language-server#412
Is it tested? How?
With test. To manual test, open any yaml which has json schema contributed with ExtensionAPI(any k8s yaml with k8s extension installed) and click on codelens over first line, it should open JSON Schema in editor tab.