Merged
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
JPinkney
reviewed
Apr 30, 2021
Contributor
JPinkney
left a comment
JPinkney
left a comment
There was a problem hiding this comment.
It looks like there's some inconsistent spacing between some methods, some do:
method1
method2
and other times its
method1
method2
fbricon
requested changes
Apr 30, 2021
… add-telemetry Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
fbricon
approved these changes
May 11, 2021
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
JPinkney
approved these changes
May 18, 2021
joshuawilson
approved these changes
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add dependency to
redhat.vscode-commonsand send telemetry data.It add hadler and pass all telemetry_event from yaml-ls.
Also it send telemetry with any errors logged in LSP communication.
What issues does this PR fix or reference?
Resolve #458