Skip to content

Restore telemetry#528

Merged
evidolob merged 1 commit intoredhat-developer:masterfrom
fbricon:telemetry2
Jun 11, 2021
Merged

Restore telemetry#528
evidolob merged 1 commit intoredhat-developer:masterfrom
fbricon:telemetry2

Conversation

@fbricon
Copy link
Copy Markdown
Contributor

@fbricon fbricon commented Jun 9, 2021

What does this PR do?

Restore telemetry collection without the need for vscode-commons. See #515.

What issues does this PR fix or reference?

Fixes #458 for good

Is it tested? How?

When debugging the yaml extension, check telemetry events in:

@evidolob
Copy link
Copy Markdown
Collaborator

evidolob commented Jun 9, 2021

@fbricon Could you remove package-lock.json file, as we now using yarn and that file is redundant.

@fbricon
Copy link
Copy Markdown
Contributor Author

fbricon commented Jun 9, 2021

@fbricon Could you remove package-lock.json file, as we now using yarn and that file is redundant.

My bad, old habits. I removed it and updated yarn.lock instead

@joshuawilson
Copy link
Copy Markdown
Member

@evidolob you could add package.lock to the .gitignore so it doesn't get accidentally committed.

@evidolob evidolob merged commit 076656b into redhat-developer:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add telemetry reporting

4 participants