Restore telemetry#528
Merged
evidolob merged 1 commit intoredhat-developer:masterfrom Jun 11, 2021
fbricon:telemetry2
Merged
Conversation
Collaborator
|
@fbricon Could you remove |
Contributor
Author
My bad, old habits. I removed it and updated yarn.lock instead |
evidolob
approved these changes
Jun 9, 2021
Member
|
@evidolob you could add package.lock to the .gitignore so it doesn't get accidentally committed. |
joshuawilson
approved these changes
Jun 10, 2021
JPinkney
approved these changes
Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restore telemetry collection without the need for vscode-commons. See #515.
What issues does this PR fix or reference?
Fixes #458 for good
Is it tested? How?
When debugging the yaml extension, check telemetry events in: