Add status bar item for JSON schema selection#643
Merged
evidolob merged 7 commits intoredhat-developer:mainfrom Dec 15, 2021
Merged
Add status bar item for JSON schema selection#643evidolob merged 7 commits intoredhat-developer:mainfrom
evidolob merged 7 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
gorkem
reviewed
Nov 16, 2021
gorkem
suggested changes
Nov 16, 2021
Collaborator
gorkem
left a comment
gorkem
left a comment
There was a problem hiding this comment.
The build seems to fail as well.
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
JPinkney
approved these changes
Nov 17, 2021
Co-authored-by: Josh Pinkney <jpinkney@redhat.com>
gorkem
suggested changes
Nov 20, 2021
Collaborator
There was a problem hiding this comment.
I suppose this should be tested together with redhat-developer/yaml-language-server#556. However I have not been able to compile the project. When I tried the instructions on CONTRIBUTING.md compilation fails. When I try to do yarn link compilation fails. At the moment, I can not test this change.
Collaborator
Author
|
@gorkem Could you share errors which you have? I try several times and all compilation pass for me. Other problem with this PR that tests on CI is failing for some reasons, locally they pass. Going to investigate that. |
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Collaborator
Author
|
@gorkem Now flow with |
gorkem
approved these changes
Nov 25, 2021
…chema-status-bar-item
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new status bar item in VSCode status bar. This status bar shows current schema used and allow to select/switch schema with UI (quick pick box). It also indicate with error background if yaml-ls uses more than one schema for file.
Demo:
Screen.Recording.2021-11-16.at.14.14.43.mov
Depends on redhat-developer/yaml-language-server#556
What issues does this PR fix or reference?
Resolve: #565
Is it tested? How?
With test