Support JSON Schema versions from schemastore#710
Merged
evidolob merged 4 commits intoredhat-developer:mainfrom Apr 1, 2022
Merged
Support JSON Schema versions from schemastore#710evidolob merged 4 commits intoredhat-developer:mainfrom
evidolob merged 4 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
gorkem
suggested changes
Mar 15, 2022
Collaborator
gorkem
left a comment
gorkem
left a comment
There was a problem hiding this comment.
Can we add some tests that are covering this functionality? When I run the tests locally they fail for me. Also, it seems to fail on CI too. Otherwise, this is good to go.
Collaborator
|
Also noticed that the version number for the schema is doubled when it's displayed on the status bar. On the example below version 2.0.0 is repeated
|
Collaborator
Author
|
@gorkem I fix all comments, could you look on this again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for versions in JSON Schema store.
Depends on redhat-developer/yaml-language-server#675
What issues does this PR fix or reference?
Resolve redhat-developer/yaml-language-server#639
Is it tested? How?