Skip to content

Msivasubramaniaan patch 1#900

Merged
msivasubramaniaan merged 3 commits intomainfrom
msivasubramaniaan-patch-1
Mar 14, 2023
Merged

Msivasubramaniaan patch 1#900
msivasubramaniaan merged 3 commits intomainfrom
msivasubramaniaan-patch-1

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Contributor

What does this PR do?

Added null check

What issues does this PR fix or reference?

Cannot read properties of undefined (reading 'findIndex')

Is it tested? How?

Yes

@msivasubramaniaan msivasubramaniaan self-assigned this Mar 13, 2023
Comment thread src/recommendation/openShiftToolkit.ts Outdated
Copy link
Copy Markdown
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msivasubramaniaan msivasubramaniaan merged commit c395794 into main Mar 14, 2023
@msivasubramaniaan msivasubramaniaan deleted the msivasubramaniaan-patch-1 branch March 14, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants