Enable telemetry in Web extension#903
Merged
msivasubramaniaan merged 1 commit intoredhat-developer:mainfrom Mar 15, 2023
Merged
Enable telemetry in Web extension#903msivasubramaniaan merged 1 commit intoredhat-developer:mainfrom
msivasubramaniaan merged 1 commit intoredhat-developer:mainfrom
Conversation
Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon
force-pushed
the
webworker-telemetry
branch
from
ea61a7b to
d7324e7
Compare
msivasubramaniaan
approved these changes
Mar 15, 2023
Contributor
msivasubramaniaan
left a comment
msivasubramaniaan
left a comment
There was a problem hiding this comment.
LGTM.
Tested on my local and able to see the event in amplitude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fred Bricon fbricon@gmail.com
What does this PR do?
Enables Telemetry when the extension runs in a Web browser
What issues does this PR fix or reference?
No linked issue
Is it tested? How?
Best way to test this is to run a CLI build:
Then launch an http server and create a tunnel to expose it online. In one terminal run:
This will start a web server on port 5000. Then, in a second terminal, execute:
This will expose your local web server to a public URL like
https://<fancy-name>-<your-IP>.loca.ltCopy that URL, open it in a browser, click on the button to enable it.
Then go to https://vscode.dev, if you already have redhat.vscode-yaml installed, uninstall it.
With the command palette (Ctrl+Shift+P/Cmd+Shift+P on mac), run the
Developer: Install Extension from Location...command.Paste your loca.lt URL
Create a new document, select YAML language, you should see the Red Hat telemetry Opt-in popup. After accepting it and you should see a startup event in Amplitude