Fix resolving schemas on web#1173
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Feb 6, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+15
to
+17
| namespace FSReadUri { | ||
| export const type: RequestType<string, string, unknown> = new RequestType('fs/readUri'); | ||
| } |
Check failure
Code scanning / ESLint
Disallow TypeScript namespaces Error
datho7561
force-pushed
the
resolve-schema-content-web
branch
from
0cfd664 to
271802e
Compare
- Use URI instead of filepath on web, since the web environment sometimes uses URIs with schemes other than `file://` for the workspace files Fixes redhat-developer/vscode-yaml#1194 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
resolve-schema-content-web
branch
from
271802e to
58c4a58
Compare
shin19991207
approved these changes
Feb 6, 2026
Member
shin19991207
left a comment
shin19991207
left a comment
There was a problem hiding this comment.
LGTM! I tested manually and it works good. Thanks, David!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use URI instead of filepath to retrieve schemas from workspace on web, since the web environment sometimes uses URIs with schemes other than
file://for the workspace filesWhat issues does this PR fix or reference?
Fixes redhat-developer/vscode-yaml#1194
Is it tested? How?
Manually, integration tests/smoke tests in vscode-yaml