Skip to content

Fix absolute-path $ref resolution for schemas without a top-level $id#1229

Merged
datho7561 merged 2 commits intoredhat-developer:mainfrom
shin19991207:chang-patch-1227
Apr 15, 2026
Merged

Fix absolute-path $ref resolution for schemas without a top-level $id#1229
datho7561 merged 2 commits intoredhat-developer:mainfrom
shin19991207:chang-patch-1227

Conversation

@shin19991207
Copy link
Copy Markdown
Member

@shin19991207 shin19991207 commented Apr 13, 2026

What does this PR do?

For schemas without a top-level $id, absolute-path $ref failed to resolve in v1.20.0 and v1.21.0.
This PR fixes the issue.

What issues does this PR fix or reference?

Fixes #1227

Is it tested? How?

  • New automated test
  • Test manually

Signed-off-by: Morgan Chang <shin19991207@gmail.com>
@shin19991207 shin19991207 requested a review from datho7561 as a code owner April 13, 2026 21:01
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fixes the bug from my testing. Thanks, Morgan!

@datho7561 datho7561 merged commit f7ea162 into redhat-developer:main Apr 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

textDocument/hover crashes with "url argument must be of type string" for schemas without $id

2 participants