Fix local sibling $ref resolution when $id does not end with file name#1230
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Apr 15, 2026
Merged
Conversation
datho7561
approved these changes
Apr 15, 2026
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good and fixes the issue. Thanks, Morgan!
…le name Signed-off-by: Morgan Chang <shin19991207@gmail.com>
datho7561
force-pushed
the
chang-patch-1228
branch
from
04f05f2 to
63d60da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implemented
fallbackBaseURLso local schema likefile:///.../repro_main_schema.jsoncan still resolve$ref: ./repro_defs.jsonfrom the local directory even if its top-level$idis something unrelated likehttps://example.com/schemas/repro-main-v1.fallbackBaseURLrepresents the actual schema resource we loaded from disk and is used for local-sibling fallback.What issues does this PR fix or reference?
Fixes #1228
Is it tested? How?