Improve completion performance#580
Merged
evidolob merged 2 commits intoredhat-developer:mainfrom Nov 10, 2021
Merged
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
JPinkney
approved these changes
Nov 9, 2021
…er into improve-completion-performance Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve completion performance by switching back to AST based JSON schema selection.
As raw parser AST not efficient as
Nodedoesn’t have link to the parentNode, so looking for parent node take a huge time. With this PR Completion performance, on big YAML file, should be close to0.23.0version.What issues does this PR fix or reference?
Resolve: redhat-developer/vscode-yaml#626
Is it tested? How?
With test