Add diagnostic and code action for unused anchor#621
Merged
evidolob merged 4 commits intoredhat-developer:mainfrom Jan 24, 2022
Merged
Add diagnostic and code action for unused anchor#621evidolob merged 4 commits intoredhat-developer:mainfrom
evidolob merged 4 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Collaborator
Author
|
cc @gorkem @remcohaszing WDYT? |
remcohaszing
approved these changes
Dec 17, 2021
Contributor
remcohaszing
left a comment
remcohaszing
left a comment
There was a problem hiding this comment.
It even includes a fixer. Awesome!
Collaborator
|
+1 good idea. I will review it later. One note. Is an unused anchor an error or a warning? |
Collaborator
Author
gorkem
reviewed
Dec 22, 2021
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
…er into unused-anchors-diagnostic Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Collaborator
Author
|
@gorkem Could you look on this again? |
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
gorkem
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It add diagnostic report for unused anchors, also it add code action which delete unused anchor.
This PR also updates the
yamlparser to2.0.0-9to be able to useCSTscrTokenfromNode.Demo:
Screen.Recording.2021-12-17.at.09.46.38.mov
What issues does this PR fix or reference?
Resolve: #587
Is it tested? How?
with test