Skip to content

changed parser when last line is empty or null#625

Merged
evidolob merged 8 commits intoredhat-developer:mainfrom
msivasubramaniaan:fix-hover-should-show-when-property-behind-with-null-value
Feb 3, 2022
Merged

changed parser when last line is empty or null#625
evidolob merged 8 commits intoredhat-developer:mainfrom
msivasubramaniaan:fix-hover-should-show-when-property-behind-with-null-value

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR related to show the hover on the property when the next line is empty/null value

What issues does this PR fix or reference?

#615

Is it tested? How?

Yes. With test cases

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 24, 2021

Coverage Status

Coverage increased (+0.07%) to 81.137% when pulling e895465 on msivasubramaniaan:fix-hover-should-show-when-property-behind-with-null-value into 8b858ad on redhat-developer:main.

Comment thread src/languageservice/parser/yamlParser07.ts Outdated
Copy link
Copy Markdown
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread src/languageservice/parser/yamlParser07.ts Outdated
@evidolob evidolob merged commit fcceb1d into redhat-developer:main Feb 3, 2022
@msivasubramaniaan msivasubramaniaan deleted the fix-hover-should-show-when-property-behind-with-null-value branch February 3, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants