Fixing SORTABLE, INDEXEMPTY and INDEXMISSING order when using RediSearch fields#3810
Merged
petyaslavova merged 3 commits intomasterfrom Oct 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the ordering of RediSearch field attributes in index creation commands. The SORTABLE attribute must appear after INDEXEMPTY and INDEXMISSING to comply with RediSearch's expected command syntax.
Key Changes:
- Reordered field attribute appending logic to place SORTABLE after INDEXEMPTY and INDEXMISSING
- Added test coverage for the fixed behavior in both sync and async test suites
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| redis/commands/search/field.py | Moved SORTABLE attribute to be appended after INDEXEMPTY and INDEXMISSING in the Field constructor |
| tests/test_search.py | Added test case verifying index creation with SORTABLE combined with INDEXEMPTY and INDEXMISSING |
| tests/test_asyncio/test_search.py | Added async version of the test case for index creation with combined attributes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vladvildanov
approved these changes
Oct 22, 2025
petyaslavova
added a commit
that referenced
this pull request
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixes #3809