fix: replace 3 bare except clauses with except Exception#3980
Merged
petyaslavova merged 3 commits intoredis:masterfrom Mar 4, 2026
Merged
fix: replace 3 bare except clauses with except Exception#3980petyaslavova merged 3 commits intoredis:masterfrom
petyaslavova merged 3 commits intoredis:masterfrom
Conversation
a39815c to
8418d0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare except clauses with except Exception.
Note
Low Risk
Low risk: only narrows doctest error handling from catching all throwables to catching standard exceptions, without changing core logic or APIs.
Overview
Updates
doctests/query_em.pyto replace three bareexcept:blocks withexcept Exception:in query examples that fall back when certain Redis query syntaxes are unsupported, avoiding catching non-exception throwables (e.g.,KeyboardInterrupt,SystemExit) while keeping the same fallback behavior.Written by Cursor Bugbot for commit 326c6cc. This will update automatically on new commits. Configure here.