Don't bundle github-reserved-names (switch to esbuild)#196
Merged
Conversation
fregante
changed the title
github-reserved-names (switch to esbuild)
Member
Author
|
What a pain. I just wanted a tree-shaker of valid JavaScript code but that doesn't exist, tree-shaking is only a feature of bundlers and minifiers, neither of which is needed here. esbuild's drop-label is the closest I could get, but esbuild replaces |
fregante
commented
Jun 28, 2024
| @@ -3,9 +3,7 @@ | |||
| export const testableUrls = new Map<string, string[]>(); | |||
|
|
|||
| export function addTests(test: string, urls: string[]): void { | |||
Member
Author
There was a problem hiding this comment.
I also tried many variations of --pure and --define. I wasn't able to drop this addTests helper from the source, it's needed to enable the tree-shaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-reserved-names#194