refactor: centralize migrator filtering to migrators#3897
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3897 +/- ##
==========================================
+ Coverage 78.21% 80.49% +2.28%
==========================================
Files 141 141
Lines 15732 15924 +192
==========================================
+ Hits 12304 12818 +514
+ Misses 3428 3106 -322 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
pre-commit.ci autofix |
Contributor
Author
|
pre-commit.ci autofix |
Contributor
Author
|
The raw number of nodes looks OK, but there are some non-trivial differences that need investigating. OLD: NEW (this PR): |
beckermr
commented
Mar 20, 2025
beckermr
commented
Mar 31, 2025
Contributor
Author
|
After a fair amount of debugging, here are the main differences, not all of which matter |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR centralizes all filtering of the graph done by the migrators to the migrators themselves. This logic was spread across multiple modules and that caused the code to be hard to maintain and unintuitive for folks adding new code. Now every migrator can compute the set of nodes it works on and the set of nodes it has completed without external code.
To do before merging:
Checklist:
Cross-refs, links to issues, etc:
closes #3888