fix: log_level argument for parse_recipe_yaml is not correct in container cli#3974
Merged
beckermr merged 2 commits intoregro:mainfrom Apr 2, 2025
Merged
fix: log_level argument for parse_recipe_yaml is not correct in container cli#3974beckermr merged 2 commits intoregro:mainfrom
beckermr merged 2 commits intoregro:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the log_level argument in the container CLI’s parse_recipe_yaml function while also updating tests to account for container usage.
- Fix log_level type annotation and argument passing in container_cli.py
- Update test signatures to support enable_containers via parametrization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_make_migrators.py | Updated test signatures to conditionally load the container fixture |
| conda_forge_tick/container_cli.py | Added explicit type annotations for log_level and passed it to _run_bot_task |
Comments suppressed due to low confidence (1)
conda_forge_tick/container_cli.py:475
- Consider whether a default value for the log_level parameter is required if it is optional, in order to ensure consistent behavior when the CLI is invoked without specifying a log level.
def parse_recipe_yaml(
naughty PyCharm was at work
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3974 +/- ##
==========================================
+ Coverage 78.16% 78.24% +0.07%
==========================================
Files 141 141
Lines 15726 15732 +6
==========================================
+ Hits 12293 12309 +16
+ Misses 3433 3423 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The newly added v1 support for
create_migration_yaml_creatoradded in #3970 is currently broken because there is an unrelated bug in theparse_recipe_yamlcontainer CLI. This PR fixes the issue.Logs: https://github.com/regro/cf-scripts/actions/runs/14226411844/job/39866904255#step:7:1546
Checklist:
Cross-refs, links to issues, etc:
FYI @xhochy