Skip to content

fix: log_level argument for parse_recipe_yaml is not correct in container cli#3974

Merged
beckermr merged 2 commits intoregro:mainfrom
ytausch:fix-parse-recipe-yaml
Apr 2, 2025
Merged

fix: log_level argument for parse_recipe_yaml is not correct in container cli#3974
beckermr merged 2 commits intoregro:mainfrom
ytausch:fix-parse-recipe-yaml

Conversation

@ytausch
Copy link
Copy Markdown
Contributor

@ytausch ytausch commented Apr 2, 2025

Description:

The newly added v1 support for create_migration_yaml_creator added in #3970 is currently broken because there is an unrelated bug in the parse_recipe_yaml container CLI. This PR fixes the issue.

Logs: https://github.com/regro/cf-scripts/actions/runs/14226411844/job/39866904255#step:7:1546

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

FYI @xhochy

@ytausch ytausch requested review from beckermr and Copilot April 2, 2025 18:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with the log_level argument in the container CLI’s parse_recipe_yaml function while also updating tests to account for container usage.

  • Fix log_level type annotation and argument passing in container_cli.py
  • Update test signatures to support enable_containers via parametrization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/test_make_migrators.py Updated test signatures to conditionally load the container fixture
conda_forge_tick/container_cli.py Added explicit type annotations for log_level and passed it to _run_bot_task
Comments suppressed due to low confidence (1)

conda_forge_tick/container_cli.py:475

  • Consider whether a default value for the log_level parameter is required if it is optional, in order to ensure consistent behavior when the CLI is invoked without specifying a log level.
def parse_recipe_yaml(

naughty PyCharm was at work
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.24%. Comparing base (3ad1758) to head (6a18497).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/container_cli.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3974      +/-   ##
==========================================
+ Coverage   78.16%   78.24%   +0.07%     
==========================================
  Files         141      141              
  Lines       15726    15732       +6     
==========================================
+ Hits        12293    12309      +16     
+ Misses       3433     3423      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beckermr beckermr added this pull request to the merge queue Apr 2, 2025
Merged via the queue into regro:main with commit d9ad82b Apr 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants