Skip to content

fix compiler stub replacement#5609

Merged
beckermr merged 3 commits intoregro:mainfrom
minrk:stub-replacement
Feb 21, 2026
Merged

fix compiler stub replacement#5609
beckermr merged 3 commits intoregro:mainfrom
minrk:stub-replacement

Conversation

@minrk
Copy link
Copy Markdown
Contributor

@minrk minrk commented Feb 20, 2026

Description:

fixes regex to substitute only the compiler("x") part instead of the whole template string, so that it remains valid if there's other stuff going on like jinja filters.

So instead of turning

${{ compiler('x') }}

into

x_compiler_stub

it is turned into

${{ 'x_compiler_stub' }}

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

this may fix #5382 (I can at least do a local call of:

text = read_recipe_yaml()

_render_recipe_yaml(text, platform_arch="linux-64", cbc_path="/path/to/openmpi-feedstock/.ci_support/linux_64_channel_targetsconda-forge_maincuda_compiler_version12.9mpi_typeconda.yam
      ⋮ l")

(note: it still fails if I don't give it a variant config due to the empty libfabric variable)

fixes regex to substitute only the `compiler("x")` part instead of the whole template string,
so that it remains valid if there's other stuff going on like jinja filters
@beckermr
Copy link
Copy Markdown
Contributor

beckermr commented Feb 20, 2026

See my comment on the issue. I think we should swallow all of the jinja.

@minrk
Copy link
Copy Markdown
Contributor Author

minrk commented Feb 20, 2026

got it. Now replaces the whole template string with the stub

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.77%. Comparing base (a3043f7) to head (2c836c5).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5609      +/-   ##
==========================================
+ Coverage   79.74%   79.77%   +0.02%     
==========================================
  Files         144      144              
  Lines       17006    17009       +3     
==========================================
+ Hits        13562    13569       +7     
+ Misses       3444     3440       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beckermr beckermr merged commit 19d033e into regro:main Feb 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openmpi not showing up in migrations

2 participants