Merged
Conversation
fixes regex to substitute only the `compiler("x")` part instead of the whole template string,
so that it remains valid if there's other stuff going on like jinja filters
Contributor
|
See my comment on the issue. I think we should swallow all of the jinja. |
Contributor
Author
|
got it. Now replaces the whole template string with the stub |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5609 +/- ##
==========================================
+ Coverage 79.74% 79.77% +0.02%
==========================================
Files 144 144
Lines 17006 17009 +3
==========================================
+ Hits 13562 13569 +7
+ Misses 3444 3440 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
beckermr
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
fixes regex to substitute only the
compiler("x")part instead of the whole template string, so that it remains valid if there's other stuff going on like jinja filters.So instead of turning
into
it is turned into
Checklist:
Cross-refs, links to issues, etc:
this may fix #5382 (I can at least do a local call of:
(note: it still fails if I don't give it a variant config due to the empty
libfabricvariable)