Skip to content

Implemented CBasePlayerWeapon::KickBack hook #738

Closed
ShadowsAdi wants to merge 5 commits intorehlds:masterfrom
ShadowsAdi:implement-cbaseplayerweapon-kickback
Closed

Implemented CBasePlayerWeapon::KickBack hook #738
ShadowsAdi wants to merge 5 commits intorehlds:masterfrom
ShadowsAdi:implement-cbaseplayerweapon-kickback

Conversation

@ShadowsAdi
Copy link
Copy Markdown
Contributor

And fixed compilation warning in weapons.cpp -> GetBaseAccuracy()

Related to rehlds/ReAPI#153
https://dev-cs.ru/threads/1056/page-13#post-122698

and fixed compilation warning in weapons.cpp -> GetBaseAccuracy()
@StevenKal
Copy link
Copy Markdown
Contributor

New hooks in end of the list, always!

@ShadowsAdi
Copy link
Copy Markdown
Contributor Author

ShadowsAdi commented Mar 19, 2022

Hm, you're right, gotta change that.
Edit: Tested it. It works without any problems.

@StevenKal
Copy link
Copy Markdown
Contributor

StevenKal commented Mar 19, 2022

The following functions after it are broken, except if you recompile ReAPI module too with new IDs, and use it.
But for people who will have "the "ReGameDLL_CS with your kickback hook", and still having old ReAPI, and, using the functions being after it (DropIdlePlayer, etc.), this will be broken, because virtual IDs will not match & point to wrong function.

Comment thread regamedll/dlls/API/CAPI_Impl.cpp
@s1lentq
Copy link
Copy Markdown
Member

s1lentq commented Sep 5, 2023

Done #849

@s1lentq s1lentq closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants