Skip to content

Romanian translations#38

Closed
edwardtfn wants to merge 4 commits intomainfrom
romanian-translations
Closed

Romanian translations#38
edwardtfn wants to merge 4 commits intomainfrom
romanian-translations

Conversation

@edwardtfn
Copy link
Copy Markdown
Collaborator

Pull Request Template for Home Assistant / Lovelace Card Repository

Overview

Please provide a brief description of the changes introduced in this pull request. Include any context that will help reviewers understand the motivation behind the changes, such as the problem you are trying to solve or the feature you are implementing.

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Documentation update
  • Refactoring
  • Other (please describe):

Checklist

Please ensure that you have completed the following tasks before submitting your pull request:

  • I have read the contributing guidelines for this project.
  • I have tested my changes against the dev branch (or another appropriate branch) and verified that they are working as expected.
  • I have updated the documentation (if applicable) to reflect my changes.
  • My changes adhere to the repository's code style guidelines.
  • My changes do not introduce any breaking changes or unexpected behaviors.

Related Issues / Pull Requests

Please include any related issues or pull requests that this change is associated with, and use the appropriate keywords (Closes, Fixes, Resolves) to automatically close the related issues when this pull request is merged.

  • Closes #issue_number
  • Fixes #issue_number
  • Resolves #issue_number

Additional Details

Completing changes for #36 which is based on original pull request by @rumbu13: AitorDB#137

Complete changes for #36 which is based on original pull request by @rumbu13: AitorDB#137
@edwardtfn edwardtfn added the release:patch (x.x.X) Bump the semantic version and release a build to HACS label Mar 27, 2023
@edwardtfn edwardtfn mentioned this pull request Mar 27, 2023
11 tasks
@ThomDietrich
Copy link
Copy Markdown

ThomDietrich commented Mar 27, 2023

#36 was still in "Draft" state, which generally means I was still working on it. That said, thanks for completing the work to add the translation here. However, you missed the reason for creating #36 in the first place: To honor the original contribution by @rumbu13, see 267fa83

@edwardtfn
Copy link
Copy Markdown
Collaborator Author

Oh no! My apologies for that.
🤦🏽‍♂️

Let's revive that one then.

@edwardtfn edwardtfn closed this Mar 27, 2023
@ThomDietrich
Copy link
Copy Markdown

Included in c1e42e3

Thanks! :)

@ThomDietrich ThomDietrich deleted the romanian-translations branch March 27, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:patch (x.x.X) Bump the semantic version and release a build to HACS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants