Skip to content
This repository was archived by the owner on Feb 9, 2024. It is now read-only.

docs: Add example for Jenkins pipeline (accessing self-hosted GitLab)#307

Merged
viceice merged 11 commits intorenovatebot:mainfrom
florianklumb:feat/add-jenkins-pipeline-example
Sep 14, 2022
Merged

docs: Add example for Jenkins pipeline (accessing self-hosted GitLab)#307
viceice merged 11 commits intorenovatebot:mainfrom
florianklumb:feat/add-jenkins-pipeline-example

Conversation

@florianklumb
Copy link
Copy Markdown
Contributor

As promised in containerbase/base#370

@florianklumb florianklumb force-pushed the feat/add-jenkins-pipeline-example branch 3 times, most recently from f3f84da to 497079f Compare June 7, 2022 17:09
Copy link
Copy Markdown
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link from root readme to this file.

@florianklumb florianklumb force-pushed the feat/add-jenkins-pipeline-example branch from e035592 to 2183c0f Compare June 8, 2022 06:13
@florianklumb
Copy link
Copy Markdown
Contributor Author

Please add a link from root readme to this file.

Done

Comment thread docs/jenkins.md Outdated
Comment thread docs/jenkins.md Outdated
Comment thread docs/jenkins.md Outdated
Comment thread docs/jenkins.md Outdated
Comment thread docs/jenkins.md Outdated
florianklumb and others added 3 commits June 8, 2022 10:46
Address Code Review

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Address Code Review

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Address Code Review

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@florianklumb florianklumb requested a review from viceice June 8, 2022 15:22
@florianklumb
Copy link
Copy Markdown
Contributor Author

So?

Copy link
Copy Markdown
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you tested this setup?

@florianklumb
Copy link
Copy Markdown
Contributor Author

florianklumb commented Jun 15, 2022

Did you tested this setup?

Seems to work, yes.

@florianklumb
Copy link
Copy Markdown
Contributor Author

I guess the line BUILDPACK = true plus its explanation can be removed as well then?

@viceice
Copy link
Copy Markdown
Member

viceice commented Jun 15, 2022

yes

Comment thread docs/jenkins.md Outdated
@viceice viceice enabled auto-merge (squash) September 14, 2022 06:38
@viceice viceice disabled auto-merge September 14, 2022 06:38
@viceice viceice changed the title Add example for Jenkins pipeline (accessing self-hosted GitLab) docs: Add example for Jenkins pipeline (accessing self-hosted GitLab) Sep 14, 2022
@viceice viceice enabled auto-merge (squash) September 14, 2022 06:38
@viceice viceice merged commit adbc8a4 into renovatebot:main Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants