Skip to content

build(pyproject): modernize license metadata and add package build CI check#459

Open
Aarogaming wants to merge 1 commit intoresemble-ai:masterfrom
Aarogaming:master
Open

build(pyproject): modernize license metadata and add package build CI check#459
Aarogaming wants to merge 1 commit intoresemble-ai:masterfrom
Aarogaming:master

Conversation

@Aarogaming
Copy link
Copy Markdown

Summary

  • modernize pyproject.toml license metadata
  • add package build verification in CI
  • keep changes scoped to packaging/release hygiene

Validation

  • python -m build --sdist --wheel

Copilot AI review requested due to automatic review settings February 13, 2026 05:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates packaging metadata and CI to improve release hygiene by modernizing declared license information and ensuring the project can be built into sdist/wheel in GitHub Actions.

Changes:

  • Update pyproject.toml license metadata.
  • Add a CI step that runs python -m build --sdist --wheel to verify package buildability.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Adjusts declared project license metadata in the PEP 621 [project] section.
.github/workflows/install_check.yml Adds a CI build step to produce sdist and wheel artifacts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

readme = "README.md"
requires-python = ">=3.10"
license = {file = "LICENSE"}
license = "MIT"
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[project].license under PEP 621 is expected to be a table (e.g., { file = "LICENSE" } or { text = "..." }). Setting it to a bare string ("MIT") is not PEP 621-compliant and can cause python -m build/setuptools to error or drop license file metadata. Consider reverting to license = { file = "LICENSE" } and (optionally) adding an SPDX-based license-expression = "MIT" if you want modern SPDX metadata.

Suggested change
license = "MIT"
license = { file = "LICENSE" }
license-expression = "MIT"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants