build(pyproject): modernize license metadata and add package build CI check#459
build(pyproject): modernize license metadata and add package build CI check#459Aarogaming wants to merge 1 commit intoresemble-ai:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates packaging metadata and CI to improve release hygiene by modernizing declared license information and ensuring the project can be built into sdist/wheel in GitHub Actions.
Changes:
- Update
pyproject.tomllicense metadata. - Add a CI step that runs
python -m build --sdist --wheelto verify package buildability.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Adjusts declared project license metadata in the PEP 621 [project] section. |
| .github/workflows/install_check.yml | Adds a CI build step to produce sdist and wheel artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| readme = "README.md" | ||
| requires-python = ">=3.10" | ||
| license = {file = "LICENSE"} | ||
| license = "MIT" |
There was a problem hiding this comment.
[project].license under PEP 621 is expected to be a table (e.g., { file = "LICENSE" } or { text = "..." }). Setting it to a bare string ("MIT") is not PEP 621-compliant and can cause python -m build/setuptools to error or drop license file metadata. Consider reverting to license = { file = "LICENSE" } and (optionally) adding an SPDX-based license-expression = "MIT" if you want modern SPDX metadata.
| license = "MIT" | |
| license = { file = "LICENSE" } | |
| license-expression = "MIT" |
Summary
pyproject.tomllicense metadataValidation
python -m build --sdist --wheel