Skip to content

fix: always set correct gst treatment #3751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vorasmit merged 1 commit into from
Oct 16, 2025
Merged

fix: always set correct gst treatment #3751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions india_compliance/gst_india/overrides/transaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1529,34 +1529,24 @@ def set_for_no_taxes(self):

def update_gst_treatment_map(self):
item_templates = set()
gst_treatments = set()
gst_treatment_map = {}

for item in self.doc.items:
item_templates.add(item.item_tax_template)
gst_treatments.add(item.gst_treatment)

if any(
gst_treatment in gst_treatments
for gst_treatment in ["Zero-Rated", "Nil-Rated"]
):
# doc changed from overseas to local sale post
# taxes added after save
_gst_treatments = frappe.get_all(
self.gst_treatment_map = frappe._dict(
frappe.get_all(
"Item Tax Template",
filters={"name": ("in", item_templates)},
fields=["name", "gst_treatment"],
as_list=True,
)
gst_treatment_map = {row.name: row.gst_treatment for row in _gst_treatments}

self.gst_treatment_map = gst_treatment_map
)

def set_default_treatment(self):
default_treatment = self.get_default_treatment()

for item in self.doc.items:
if item.gst_treatment in ("Zero-Rated", "Nil-Rated"):
item.gst_treatment = self.gst_treatment_map.get(item.item_tax_template)
item.gst_treatment = self.gst_treatment_map.get(item.item_tax_template)

if not item.gst_treatment or not item.item_tax_template:
item.gst_treatment = default_treatment
Expand Down
⚡