Skip to content

fix: always set correct gst treatment (backport #3751)#3753

Merged
mergify[bot] merged 1 commit intoversion-15-hotfixfrom
mergify/bp/version-15-hotfix/pr-3751
Oct 16, 2025
Merged

fix: always set correct gst treatment (backport #3751)#3753
mergify[bot] merged 1 commit intoversion-15-hotfixfrom
mergify/bp/version-15-hotfix/pr-3751

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Oct 16, 2025

Issue: incorrect gst treatment if the item tax template is changed from the backend or the item tax template is updated from exempted to taxable.

Steps to replicate:

  • Set the item tax template in the item as 18%.
  • Create a Sales Invoice and save it.
  • Item tax template will be 18% and gst treatment will be taxable.
  • Change the item tax template in Item to Exempted
  • Again, save the invoice.

GST treatment will be Taxable, but the Item Tax Template will be Exempted because erpnext changed it.

Summary by CodeRabbit

  • Refactor
    • Optimized GST treatment mapping logic for improved transaction processing efficiency.

This is an automatic backport of pull request #3751 done by [Mergify](https://mergify.com).

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 16, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.89%. Comparing base (ed09675) to head (f189648).
⚠️ Report is 2 commits behind head on version-15-hotfix.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           version-15-hotfix    #3753      +/-   ##
=====================================================
- Coverage              59.91%   59.89%   -0.02%     
=====================================================
  Files                    140      140              
  Lines                  14799    14792       -7     
=====================================================
- Hits                    8867     8860       -7     
  Misses                  5932     5932              
Files with missing lines Coverage Δ
...ndia_compliance/gst_india/overrides/transaction.py 83.63% <100.00%> (-0.13%) ⬇️

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify mergify Bot merged commit 6f0d0f0 into version-15-hotfix Oct 16, 2025
14 checks passed
@mergify mergify Bot deleted the mergify/bp/version-15-hotfix/pr-3751 branch October 16, 2025 11:18
@india-compliance-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 15.23.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants