fix: try to log response content even if not JSON

[sagarvora]

Summary by CodeRabbit

• Bug Fixes
  • Improved error logging for API responses, ensuring diagnostic information including response status and content is properly captured even when responses cannot be parsed as JSON format, enabling better troubleshooting and debugging capabilities.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The change adds initialization of the response variable to None and introduces conditional logging in the finally block to capture non-JSON or unparsable HTTP responses, ensuring output is logged even when response parsing fails.

Changes

Cohort / File(s)	Summary
API Response Logging Enhancement india_compliance/gst_india/api_classes/base.py	Initialize response variable to None in _make_request method; add fallback logging in finally block to output HTTP status code and text content when response exists but cannot be parsed as JSON

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

• Minor initialization and defensive logging enhancement in a single file
• Low logic density with straightforward null-checking pattern
• Limited scope with clear intent to improve error observability

Poem

🐰 A response that's lost in translation,
No JSON, just confusion and frustration!
But now we log what's left behind,
The status and the text combined—
No silent failures, all eyes aligned! 🔍

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a29b900 and 8344a2e.

📒 Files selected for processing (1)

• india_compliance/gst_india/api_classes/base.py (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}