Skip to content

feat: enable total row addition in Bill of Entry Summary report#3799

Merged
vorasmit merged 1 commit intoresilient-tech:developfrom
karm1000:report/boe-summary/add-total-row
Nov 21, 2025
Merged

feat: enable total row addition in Bill of Entry Summary report#3799
vorasmit merged 1 commit intoresilient-tech:developfrom
karm1000:report/boe-summary/add-total-row

Conversation

@karm1000
Copy link
Copy Markdown
Member

@karm1000 karm1000 commented Nov 19, 2025

Summary by CodeRabbit

  • Chores
    • Modified Bill of Entry Summary report configuration to enable total row display functionality and add translation data parameter handling
    • Introduced letterhead and timeout configuration fields for improved report management
    • Refreshed file metadata and adjusted internal structure formatting

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 19, 2025

Walkthrough

This change updates the bill of entry summary report configuration file by enabling total row display, adding translation data and letterhead parameters, setting a timeout value, and updating the modification timestamp.

Changes

Cohort / File(s) Summary
Bill of Entry Summary Configuration
india_compliance/gst_india/report/bill_of_entry_summary/bill_of_entry_summary.json
Updated configuration parameters: add_total_row set to 1, added add_translate_data, letterhead, and timeout fields; refreshed timestamp

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Configuration-only changes with no logic modifications
  • Parameter value updates in a single JSON file
  • Low risk of introducing errors

Poem

🐰 A config so fine, now ready to shine,
With rows tallied up and translations in line,
Letterheads placed, timeouts precise—
The bill of entry? Now perfectly nice! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: enabling total row addition in the Bill of Entry Summary report, which matches the primary configuration update (add_total_row: 0 to 1).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5c8bc2 and 44ecf73.

📒 Files selected for processing (1)
  • india_compliance/gst_india/report/bill_of_entry_summary/bill_of_entry_summary.json (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Python Unit Tests
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Mergify Merge Protections
  • GitHub Check: Summary
🔇 Additional comments (2)
india_compliance/gst_india/report/bill_of_entry_summary/bill_of_entry_summary.json (2)

2-2: Total row configuration change aligns with PR objective.

The add_total_row field has been correctly enabled (0 → 1), which directly supports the PR objective of enabling total row addition in the Bill of Entry Summary report.


3-3: Clarify the scope of configuration changes.

The PR objective focuses on enabling total rows, but this change introduces three additional modifications not mentioned in the PR description:

  • Line 3: add_translate_data (new field, value: 0)
  • Line 12: letterhead (new field, value: null)
  • Line 36: timeout (new field, value: 0)

Please confirm whether these additions are intentional and necessary, or if they should be separated into distinct pull requests. Additionally, verify that the timeout value of 0 produces the intended behavior (e.g., no timeout, use default, etc.) in the context of Frappe Report execution.

Also applies to: 12-12, 36-36

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vorasmit vorasmit merged commit 9fa4f8f into resilient-tech:develop Nov 21, 2025
10 of 12 checks passed
mergify Bot added a commit that referenced this pull request Nov 21, 2025
…tfix/pr-3799

feat: enable total row addition in Bill of Entry Summary report (backport #3799)
mergify Bot added a commit that referenced this pull request Nov 21, 2025
…tfix/pr-3799

feat: enable total row addition in Bill of Entry Summary report (backport #3799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants