Skip to content

fix(ims): also fetch original_bill_date and original_bill_no fields in Inward Supply#3800

Merged
vorasmit merged 1 commit intoresilient-tech:developfrom
karm1000:ims/add-oinum-oidt-field
Nov 21, 2025
Merged

fix(ims): also fetch original_bill_date and original_bill_no fields in Inward Supply#3800
vorasmit merged 1 commit intoresilient-tech:developfrom
karm1000:ims/add-oinum-oidt-field

Conversation

@karm1000
Copy link
Copy Markdown
Member

@karm1000 karm1000 commented Nov 20, 2025

Fixes: https://support.frappe.io/helpdesk/tickets/53643

Summary by CodeRabbit

  • New Features
    • Added capture of original bill date and original bill number in the GST Invoice Management System, allowing users to record and track additional invoice reference details for inward supplies.

✏️ Tip: You can customize this high-level summary in your review settings.

@karm1000 karm1000 requested a review from vorasmit November 20, 2025 06:26
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 20, 2025

Walkthrough

The InwardSupply.get_fields() method now includes two additional fields — original_bill_date and original_bill_no — in its base field list, expanding the fields returned by queries without changing method signatures or control flow.

Changes

Cohort / File(s) Summary
InwardSupply field expansion
india_compliance/gst_india/doctype/gst_invoice_management_system/__init__.py
Added original_bill_date and original_bill_no to the base fields list in InwardSupply.get_fields()

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Single, localized change to a field list.
  • Review focus: confirm the two new field names exist in the data model and are used correctly in downstream queries.

Poem

A rabbit nibbles through the code, so spry,
Adding bill dates and numbers by and by,
Queries hum with one more tune,
Invoices brighter by the moon,
Hopping data safe and shy. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding two fields (original_bill_date and original_bill_no) to the InwardSupply class fetching logic.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efeb232 and 5b84e49.

📒 Files selected for processing (1)
  • india_compliance/gst_india/doctype/gst_invoice_management_system/__init__.py (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • india_compliance/gst_india/doctype/gst_invoice_management_system/init.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Python Unit Tests
  • GitHub Check: Mergify Merge Protections
  • GitHub Check: Summary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@karm1000 karm1000 force-pushed the ims/add-oinum-oidt-field branch from efeb232 to 5b84e49 Compare November 20, 2025 09:02
@karm1000 karm1000 changed the title feat: add original bill date and number fields to InwardSupply class fix(ims): also fetch original_bill_date and original_bill_no fields in Inward Supply Nov 20, 2025
@vorasmit vorasmit merged commit 96a4a94 into resilient-tech:develop Nov 21, 2025
11 of 13 checks passed
mergify Bot added a commit that referenced this pull request Nov 21, 2025
…tfix/pr-3800

fix(ims): also fetch original_bill_date and original_bill_no fields in Inward Supply (backport #3800)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants