Skip to content

fix: correct taxable amount when group by invoice in GST Purchase Register#4027

Merged
ljain112 merged 1 commit intoresilient-tech:developfrom
ljain112:fix-gst-pur-reg-taxable-value
Feb 25, 2026
Merged

fix: correct taxable amount when group by invoice in GST Purchase Register#4027
ljain112 merged 1 commit intoresilient-tech:developfrom
ljain112:fix-gst-pur-reg-taxable-value

Conversation

@ljain112
Copy link
Copy Markdown
Member

Issue: The taxable value was not getting summed when the group by invoice was selected.

Frappe Support Issue: https://support.frappe.io/desk/hd-ticket/60930

@ljain112 ljain112 changed the title fix:correct taxable amount when group by invoice in GST Purchase Register fix: correct taxable amount when group by invoice in GST Purchase Register Feb 25, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 25, 2026

📝 Walkthrough

Walkthrough

A public constant AMOUNT_FIELDS in the GST India GSTR-3B utility module was updated to include "taxable_value" as the first element in its tuple. The constant previously contained six tax-related amount fields and now includes this additional field to expand the set of fields aggregated during per-invoice data computation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

backport, version-15-hotfix

Suggested reviewers

  • vorasmit
  • karm1000
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is directly related to the changeset, explaining the issue being fixed (taxable value not being summed when grouping by invoice) and linking to the support ticket.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'fix: correct taxable amount when group by invoice in GST Purchase Register' directly matches the PR's main objective of fixing taxable value summation in the grouped-by-invoice view, and the code change adds 'taxable_value' to AMOUNT_FIELDS to achieve this fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ljain112 ljain112 merged commit a41c7fe into resilient-tech:develop Feb 25, 2026
12 of 13 checks passed
ljain112 added a commit that referenced this pull request Feb 25, 2026
…tfix/pr-4027

fix: correct taxable amount when group by invoice in GST Purchase Register (backport #4027)
ljain112 added a commit that referenced this pull request Feb 25, 2026
…tfix/pr-4027

fix: correct taxable amount when group by invoice in GST Purchase Register (backport #4027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants