fix: correct taxable amount when group by invoice in GST Purchase Register#4027
Merged
ljain112 merged 1 commit intoresilient-tech:developfrom Feb 25, 2026
Merged
Conversation
📝 WalkthroughWalkthroughA public constant Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
karm1000
approved these changes
Feb 25, 2026
ljain112
added a commit
that referenced
this pull request
Feb 25, 2026
…tfix/pr-4027 fix: correct taxable amount when group by invoice in GST Purchase Register (backport #4027)
ljain112
added a commit
that referenced
this pull request
Feb 25, 2026
…tfix/pr-4027 fix: correct taxable amount when group by invoice in GST Purchase Register (backport #4027)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: The taxable value was not getting summed when the group by invoice was selected.
Frappe Support Issue: https://support.frappe.io/desk/hd-ticket/60930