fix: updated fix for the permission issue according to new structure (backport #4268)#4270
Merged
ljain112 merged 1 commit intoversion-15-hotfixfrom Apr 30, 2026
Merged
Conversation
Confidence Score: 5/5Safe to merge — minimal, targeted fix with no regressions introduced Single-line change that correctly addresses the DoesNotExistError for unsaved documents. Doctype-level permission is still enforced, so there is no meaningful security regression. No P0/P1 findings. No files require special attention
|
| Filename | Overview |
|---|---|
| india_compliance/gst_india/utils/init.py | Removes doc=party from frappe.has_permission call in check_duplicate_party to fix DoesNotExistError when checking GSTIN/PAN on a new, unsaved party document |
Reviews (1): Last reviewed commit: "fix: updated fix for the permission issu..." | Re-trigger Greptile
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Member
|
@Mergifyio rebase |
(cherry picked from commit 672eac7)
Contributor
Author
✅ Branch has been successfully rebased |
ljain112
force-pushed
the
mergify/bp/version-15-hotfix/pr-4268
branch
from
5c05b97 to
5bdba15
Compare
ljain112
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When user makes a new, unsaved Supplier/Customer/Company and adds GSTIN to it, the system gives a DoesNotExistError error.
This is an automatic backport of pull request #4268 done by Mergify.