Skip to content

test: ensure Property Setter is deleted before testing track_changes validation#4277

Merged
ljain112 merged 1 commit intoresilient-tech:version-15-hotfixfrom
ljain112:fix-test
Apr 30, 2026
Merged

test: ensure Property Setter is deleted before testing track_changes validation#4277
ljain112 merged 1 commit intoresilient-tech:version-15-hotfixfrom
ljain112:fix-test

Conversation

@ljain112
Copy link
Copy Markdown
Member

No description provided.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 30, 2026

Confidence Score: 5/5

Safe to merge — the change is a minimal, targeted test setup fix with no production code impact.

The only change is the addition of a database-level delete in test setup to ensure idempotency. It correctly targets the exact record created later in the test, uses the standard Frappe DB API, and does not affect any production code paths.

No files require special attention.

Important Files Changed

Filename Overview
india_compliance/audit_trail/overrides/test_property_setter.py Adds a frappe.db.delete call before the test to ensure any pre-existing Property Setter record for Purchase Invoice/track_changes is removed, making the test idempotent across repeated runs.

Reviews (1): Last reviewed commit: "test: ensure Property Setter is deleted ..." | Re-trigger Greptile

@ljain112 ljain112 merged commit 9f760b1 into resilient-tech:version-15-hotfix Apr 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant