test: ensure Property Setter is deleted before testing track_changes validation#4277
Merged
ljain112 merged 1 commit intoresilient-tech:version-15-hotfixfrom Apr 30, 2026
Merged
Conversation
Up to standards ✅🟢 Issues
|
Confidence Score: 5/5Safe to merge — the change is a minimal, targeted test setup fix with no production code impact. The only change is the addition of a database-level delete in test setup to ensure idempotency. It correctly targets the exact record created later in the test, uses the standard Frappe DB API, and does not affect any production code paths. No files require special attention.
|
| Filename | Overview |
|---|---|
| india_compliance/audit_trail/overrides/test_property_setter.py | Adds a frappe.db.delete call before the test to ensure any pre-existing Property Setter record for Purchase Invoice/track_changes is removed, making the test idempotent across repeated runs. |
Reviews (1): Last reviewed commit: "test: ensure Property Setter is deleted ..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.