Skip to content

fix: correct report name for tax withholding details#4284

Open
ljain112 wants to merge 1 commit intoresilient-tech:version-14-hotfixfrom
ljain112:fix-tds-v14
Open

fix: correct report name for tax withholding details#4284
ljain112 wants to merge 1 commit intoresilient-tech:version-14-hotfixfrom
ljain112:fix-tds-v14

Conversation

@ljain112
Copy link
Copy Markdown
Member

@ljain112 ljain112 commented May 6, 2026

App Versions

{
	"erpnext": "14.92.14",
	"frappe": "14.101.1",
	"hrms": "14.38.1",
	"india_compliance": "14.35.0",
	"insights": "2.2.13",
	"payments": "14.0.0"
}

Route

query-report/Tax Withholding Details-India

Traceback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 103, in application
    response = frappe.api.handle()
  File "apps/frappe/frappe/api.py", line 60, in handle
    data = frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 50, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 85, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1628, in call
    return fn(*args, **newargs)
  File "apps/frappe/frappe/desk/query_report.py", line 188, in get_script
    "script": render_include(script),
  File "apps/frappe/frappe/model/utils/__init__.py", line 72, in render_include
    with open(frappe.get_app_path(app, app_path), encoding="utf-8") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'apps/erpnext/erpnext/accounts/report/tax_withholding_details/tax_withholding_details.js'

Request Data

{
	"type": "POST",
	"args": {
		"report_name": "Tax Withholding Details-India"
	},
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/frappe.desk.query_report.get_script"
}

Response Data

{
	"exception": "FileNotFoundError: [Errno 2] No such file or directory: 'apps/erpnext/erpnext/accounts/report/tax_withholding_details/tax_withholding_details.js'"
}

@codacy-production
Copy link
Copy Markdown

Not up to standards ⛔

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 6, 2026

Confidence Score: 5/5

Safe to merge — the change is a targeted two-line fix that corrects a broken file include and its corresponding report alias.

The change is minimal and surgical: it replaces a stale include path and report name with ones that already work in the Python layer, directly fixing a reproducible crash with no side-effects on other paths.

No files require special attention; the untouched tax_withholding_details_india.json still carries a stale reference_report value, but this is metadata-only for a Script Report and does not affect runtime behaviour.

Important Files Changed

Filename Overview
india_compliance/income_tax_india/report/tax_withholding_details_india/tax_withholding_details_india.js Fixes broken JS include by pointing to tds_payable_monthly.js instead of the removed tax_withholding_details.js, and updates the frappe.query_reports alias accordingly — aligning the JS with the Python file which already imports from tds_payable_monthly.

Reviews (1): Last reviewed commit: "fix: correct report name for tax withhol..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant