Skip to content

change dynamic schedule set_schedule default persist#637

Open
ceshihao wants to merge 1 commit intoresque:masterfrom
ceshihao:dynamic_set_schedule_default_persist
Open

change dynamic schedule set_schedule default persist#637
ceshihao wants to merge 1 commit intoresque:masterfrom
ceshihao:dynamic_set_schedule_default_persist

Conversation

@ceshihao
Copy link
Copy Markdown

@ceshihao ceshihao commented Feb 2, 2018

To improve the incompatible problem #633

@carsonreinke
Copy link
Copy Markdown
Contributor

@ceshihao Totally agree with this. I believe this would be a breaking change with semantic versioning, so it would have to be included in v5.

There is some test failures from the default change, probably just simply need to set persist: false for this cases.

@carsonreinke carsonreinke added this to the Release v5.0.0 milestone Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants