Skip to content

Fix flaky test by using strings instead of symbols for JSON-serialized args #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
top-sigrid wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −5
Open

Fix flaky test by using strings instead of symbols for JSON-serialized args #813

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b139a60
Fix test failig in Ruby 2.4
top-sigrid Dec 25, 2025
8d5b47e
remove comments
top-sigrid Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/scheduler_hooks_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,18 @@ def enqueued

test 'before_schedule hook that does not return false should be enqueued' do
enqueue_time = Time.now + 1
SomeRealClass.expects(:before_schedule_example).with(:foo)
SomeRealClass.expects(:after_schedule_example).with(:foo)
Resque.enqueue_at(enqueue_time.to_i, SomeRealClass, :foo)
SomeRealClass.expects(:before_schedule_example).with('foo')
SomeRealClass.expects(:after_schedule_example).with('foo')
Resque.enqueue_at(enqueue_time.to_i, SomeRealClass, 'foo')
assert_equal(1, Resque.delayed_timestamp_size(enqueue_time.to_i),
'job should be enqueued')
end

test 'before_schedule hook that returns false should not be enqueued' do
enqueue_time = Time.now + 1
SomeRealClass.expects(:before_schedule_example).with(:foo).returns(false)
SomeRealClass.expects(:before_schedule_example).with('foo').returns(false)
SomeRealClass.expects(:after_schedule_example).never
Resque.enqueue_at(enqueue_time.to_i, SomeRealClass, :foo)
Resque.enqueue_at(enqueue_time.to_i, SomeRealClass, 'foo')
assert_equal(0, Resque.delayed_timestamp_size(enqueue_time.to_i),
'job should not be enqueued')
end
Expand Down
Loading
⚡